Repository navigation
fix(app): reread files when opening a preview - #51036
Merged
Merged
Conversation
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser.previewand file links in the timeline showed old file content. This was true even when you closed and opened the tab again.Cause
useFile().load(path)returns early when the file is already loaded..git/HEADand.hg/branch, so the app never gets afilesystem.changedevent for workspace files. The stored copy stays until the cache evicts it.flowchart LR A[browser.preview / file link] --> B["file.load(path)"] B -->|already loaded| C[show stored copy ❌] B -->|"{ force: true }"| D["GET /api/fs/read"] --> E[show current file ✅]Fix
openTabinpackages/app/src/session/files/open-artifact.tsxnow callsfile.load(path, { force: true }).e2e/regression/artifact-reopen.spec.ts: open a file, change it, close the tab, open it again, and expect the new content.The file on disk says
second draftin both images.