Repository navigation
fix(cli): redact credentials in debug config - #50957
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50915
Always redact credential-named config values, all configured HTTP header values, and credential-bearing URLs in
opencode debug config. Preserve source ordering and the server-side config. Full***masks avoid exposing fragments of short keys. There is no unmasking flag; this is not a general-purpose secret scanner for arbitrary user strings.Tests:
bun test test/debug-config.test.ts --timeout 90000;bun typecheck(frompackages/cli).Requested by: @rekram1-node (Aiden via Slack)