Skip to content

fix(tui): span the vertical tab pulse across the rail - #50836

Closed
Veld101 wants to merge 1 commit into
anomalyco:devfrom
Veld101:tui-pulse-width
Closed

Veld101 wants to merge 1 commit into
anomalyco:devfrom
Veld101:tui-pulse-width

Conversation

@Veld101

@Veld101 Veld101 commented Sep 23, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #50426

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

With tabs.layout: "vertical", the running pulse and the separator strips above and below a tab were clipped to a hardcoded 10 columns. On a wide rail that reads as a short stray stripe instead of spanning the tab.

VerticalSessionTabs passed width={indicatorWidth} (10) to every TabPulse. The horizontal layout passes no width, so it gets TabPulse's default "100%". This removes the constant and the four width props so the vertical rail spans its tab the same way the horizontal layout already does. Nothing else changes.

How did you verify your code works?

New test vertical rail pulse spans the tab instead of a fixed 10 columns renders the vertical rail at width 24 with a running tab and checks where the separator row's spans start. Before the change the starts are [0, 3, 6, 10, 24] — the pulse stops at column 10. After, the row reaches the rail edge without a 10-column boundary.

bun test test/component/session-tabs-rail.test.tsx test/component/session-tabs-status.test.tsx \
  test/component/session-tabs-mouse.test.tsx test/component/session-tabs-marquee.test.ts \
  test/component/tab-pulse.test.tsx    # 20 pass, 0 fail
bun typecheck                          # packages/tui, clean
bun run lint                           # clean

The test only relies on span boundaries, not colors, so it is not sensitive to the theme or animation frame.

Screenshots / recordings

A text recording of TUI escape output is not meaningful here; the test captures the rendered span layout and the before/after boundaries are listed above.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tui: vertical session tabs render the working pulse only 10 columns wide

1 participant