Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
14ee68b to
64a7ac1
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #50426
Type of change
What does this PR do?
With
tabs.layout: "vertical", the running pulse and the separator strips above and below a tab were clipped to a hardcoded 10 columns. On a wide rail that reads as a short stray stripe instead of spanning the tab.VerticalSessionTabspassedwidth={indicatorWidth}(10) to everyTabPulse. The horizontal layout passes no width, so it getsTabPulse's default"100%". This removes the constant and the fourwidthprops so the vertical rail spans its tab the same way the horizontal layout already does. Nothing else changes.How did you verify your code works?
New test
vertical rail pulse spans the tab instead of a fixed 10 columnsrenders the vertical rail at width 24 with a running tab and checks where the separator row's spans start. Before the change the starts are[0, 3, 6, 10, 24]— the pulse stops at column 10. After, the row reaches the rail edge without a 10-column boundary.The test only relies on span boundaries, not colors, so it is not sensitive to the theme or animation frame.
Screenshots / recordings
A text recording of TUI escape output is not meaningful here; the test captures the rendered span layout and the before/after boundaries are listed above.
Checklist