Repository navigation
fix(tui): only close session tabs when the session is missing - #50826
Closed
rekram1-node wants to merge 2 commits into
Closed
rekram1-node wants to merge 2 commits into
rekram1-node wants to merge 2 commits into
Conversation
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The session route closed its tab whenever reloading the session failed. That includes a server that is still starting, one that is shutting down, or one that can't be reached at all. Because the TUI reloads the open session every time its event stream reconnects, restarting or updating the background service while TUIs are open could close tabs: each short-lived reconnect failed the reload, closed the current tab, and moved to the previous tab, which could then fail the same way.
Now the tab closes, or the TUI goes home when tabs are disabled, only when the server returns
SessionNotFoundError. Other failures still show the error toast but keep the session open, and the next reconnect reloads it.Evidence
In the service log from a real restart, TUI requests for open sessions got
503from a service that was still starting, and those tabs disappeared fromtabs.json. No tab-close tool calls, snoozes, or session deletions account for them.Verification
404 {"_tag":"SessionNotFoundError",...}, and the generated client's error passesisSessionNotFoundError. An existing session loads normally. An unreachable server throwsClientError("Transport"), which does not pass it.bun run check