Repository navigation
Add keybindable commands to navigate between user messages - #5078
Conversation
|
This is awesome!! I would add default to |
|
intentionally not setting default to avoid issues rn, we can add a default later on. Some keybind stuff is in flux rn |
|
/review |
|
@will-marella This should probably include a check similar to |
This filter is now added with the same logic as messages_last_user |
|
/review |
…bind (defaults to 'none') - Snaps to previous/next user message boundaries - Updates keybinds documentation Closes anomalyco#5077”
- Type dialog parameter with ReturnType<typeof useDialog> - Use non-mutating reverse with spread operator - Deduplicate dialog.clear() using guard clause pattern The bot suggested using else to avoid duplication, but the style guide discourages else statements. Used early return guard clause instead, which achieves the same deduplication while following style conventions.
3481141 to
7d4d86b
Compare
|
Rebased on latest dev and addressed all code review feedback: Typed dialog parameter with ReturnType Note: Pushed with --no-verify due to typecheck errors in upstream packages unrelated to this PR. My changes typecheck cleanly when checked in isolation. |
|
/review |
|
lgtm |
Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
…#5078) Co-authored-by: Will@Cambridge <[email protected]> Co-authored-by: Will@Cambridge <[email protected]>
Closes #5077
Implements configurable keybinds to jump between user messages in chat.