Skip to content

fix(core): degrade malformed tool-result content instead of crashing prepare - #50776

Closed
twotimemonger wants to merge 2 commits into
anomalyco:devfrom
twotimemonger:fix/malformed-tool-result
Closed

twotimemonger wants to merge 2 commits into
anomalyco:devfrom
twotimemonger:fix/malformed-tool-result

Conversation

@twotimemonger

@twotimemonger twotimemonger commented Sep 23, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #50775

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

unsupportedParts and boundImages assume every tool-result with result.type === "content" has an array value. When one shows up without it, the .map throws out of prepare and the whole session drain dies with it, leaving the session permanently stuck (every subsequent prompt hits the same part).

This replaces such parts with a short text placeholder instead of throwing, and skips them in the image-byte accounting.

One thing worth calling out: just passing the part through doesn't work here, because Message.make re-validates the message right after and throws on the schema violation anyway. Swapping in a valid text result is the only way I found that actually lets the turn continue.

How did you verify your code works?

Added two tests in packages/core/test/session-model-request.test.ts feeding a malformed tool-result part (content result with value: undefined) through both functions; they used to throw TypeError: part.result.value.map is not a function, now they degrade to the placeholder. bun test test/session-model-request.test.ts passes (8/8, existing tests unaffected).

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to drain Session: one malformed tool result wedges the whole session

1 participant