Skip to content

fix(app): respect RTL Windows caption controls - #50661

Closed
opencode-agent[bot] wants to merge 1 commit into
devfrom
windows-rtl-titlebar
Closed

opencode-agent[bot] wants to merge 1 commit into
devfrom
windows-rtl-titlebar

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • position the Windows renderer titlebar from env(titlebar-area-x) as well as sizing it from env(titlebar-area-width)
  • keep app controls out of native caption controls when Windows mirrors them to the left for an RTL layout
  • preserve the existing right-side caption-control fallback and non-Windows layout

Related: #35388, #37779

Verification

  • bun typecheck (packages/app)
  • bun typecheck (packages/desktop)
  • bun test --conditions=solid --preload ./happydom.ts ./src/shell/titlebar (packages/app): 26 passed
  • bun node_modules/.bin/vite build (packages/app)
  • bun run lint (repository root)

Native Windows visual verification is still needed; the shared Windows development box was unreachable during this run.

Requested by: @Brendonovich (Brendan via Slack)

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant