Skip to content

fix(core): scope compound permission saves - #50659

Closed
PanAchy wants to merge 6 commits into
anomalyco:devfrom
PanAchy:always-allow-scope
Closed

fix(core): scope compound permission saves#50659
PanAchy wants to merge 6 commits into
anomalyco:devfrom
PanAchy:always-allow-scope

Conversation

@PanAchy

@PanAchy PanAchy commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #50649

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Associates each compound-command resource with its save pattern, then persists only the patterns whose resources resolved to ask.

npm test && git status
├─ npm test    ask   → save npm test *
└─ git status allow → do not save

Callers with independent save arrays keep their existing behavior.

How did you verify your code works?

  • Ran bun test test/permission.test.ts test/tool-shell.test.ts from packages/core.
  • Ran bun typecheck from packages/core.
  • Reproduced the old and new behavior with the same opencode-drive fixture.

Screenshots / recordings

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

This was referenced Sep 25, 2026
Closed
Open
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:14
@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Oct 22, 2026
@opencodejr opencodejr Bot mentioned this pull request Oct 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compound shell approval saves already-allowed command patterns

1 participant

@PanAchy