Skip to content

fix(server): disable keepAliveTimeout so large responses are not cut mid-body - #50507

Closed
CalyxLab wants to merge 1 commit into
anomalyco:devfrom
CalyxLab:fix/server-keepalive-large-responses
Closed

fix(server): disable keepAliveTimeout so large responses are not cut mid-body#50507
CalyxLab wants to merge 1 commit into
anomalyco:devfrom
CalyxLab:fix/server-keepalive-large-responses

Conversation

@CalyxLab

@CalyxLab CalyxLab commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #50505

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The web UI fails to open large sessions with ClientError: Transport / TypeError: Load failed: the server writes the session's message list as one big body via a single res.end(body), and under Bun server.keepAliveTimeout (default 5s) destroys the socket while that body is still draining to a client reading slower than ~1 MB/s — after end() there are no further write() calls to reset Bun's timer. Node is unaffected; chunked HttpServerResponse.stream responses are unaffected. Details and repro in #50505.

This PR sets server.keepAliveTimeout = 0 on the createServer() instance in bind(), so in-flight responses are never cut mid-body.

How did you verify your code works?

Against opencode serve from source, fetching a ~9.5 MB session response with a throttled client (curl --limit-rate 600K):

  • before: curl: (18) transfer closed with 3968156 bytes remaining to read (~9.5 s)
  • after: complete transfer, bytes=9517142 time=16.2s

Also verified with a minimal Bun + @effect/platform-node repro (no opencode code): killed at ~9 s before the change, completes after. bun run test in packages/server: 58 pass, 0 fail.

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@CalyxLab CalyxLab mentioned this pull request Sep 22, 2026
Closed
@CalyxLab
CalyxLab force-pushed the fix/server-keepalive-large-responses branch from db07f78 to d2fdccf Compare September 22, 2026 10:40
@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:13
@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Large session responses get cut mid-body under Bun (web UI: ClientError: Transport / Load failed)

1 participant

@CalyxLab