Repository navigation
fix(tui): keep session scope toggle usable in the picker - #50432
Closed
Mattheinrichs wants to merge 1 commit into
Closed
Mattheinrichs wants to merge 1 commit into
Mattheinrichs wants to merge 1 commit into
Conversation
The session picker is a dialog, so it pushes the "modal" mode and the session_directory_filter binding registered for the base mode became inactive while the picker was open. Move it to the mode-less global set so it keeps working, and skip clearing the dialog on toggle so the re-listed scope stays visible. The Session list footer now names the current scope and, when bound, the key that flips it. Fixes anomalyco#42060 Fixes anomalyco#42058 Re-submission of the auto-closed anomalyco#42056; original fix by @thepigdestroyer.
This was referenced Sep 21, 2026
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42060
Closes #42058
Type of change
What does this PR do?
A key bound to
app.toggle.session_directory_filterdoes nothing while the session picker is open. The picker is aDialog, and dialogs push the"modal"keymap mode, but the command was registered inappBindingCommands, which is scoped to the base mode — so that layer is inactive exactly where the toggle is used.I moved the command into the mode-less
appGlobalBindingCommandsset, and stopped the toggle from callingdialog.clear()while the picker is open, so the list re-queriessync.session.query()and re-lists in place instead of hiding the result.The session list footer now also shows the current scope and, when the command is bound, the key that flips it (#42058).
This is a re-submission of #42056, which was closed by the PR cleanup bot (created >1 month, <2 reactions) rather than on review. Original fix by @thepigdestroyer.
How did you verify your code works?
cd packages/tui && bun typecheck— cleancd packages/tui && bun test— 197 pass, 1 skip, 0 failappGlobalBindingCommands/appBindingCommandslayers, pushes"modal", and asserts the toggle stays active while a base-mode command drops.sessionScopeLabelcases added to the dialog session list tests.Screenshots / recordings
TUI keymap/footer change; no screenshot captured.
Checklist