Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 of 6 tasks
Author
|
Superseded by #50801 on �2. dev is not where merges land (recent merges are overwhelmingly into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12503
Closes #12605
Type of change
What does this PR do?
Support comma-separated font family input in settings (e.g.,
Consolas, KaiTi).Previously, entering
Consolas, KaiTiwould be treated as a single font name and wrapped in quotes, making it invalid CSS. Now the input is split by commas and each font name is processed independently.Also fixes
fontSizenot being applied to the DOM — it was stored in settings but never written to the--font-size-baseCSS variable.How did you verify your code works?
Consolas, KaiTiin the code font setting → inspected--font-family-monoCSS variable → confirmed it outputsConsolas, KaiTi, ui-monospace, ...Consolas→ still works correctly楷体→ correctly wrapped in quotes"楷体"--font-size-baseCSS variable now updates when fontSize setting changesScreenshots / recordings
Not a visual UI change — behavior verified via CSS variable inspection.
Checklist