Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
I've verified the fix in the Windows desktop development app and added a screenshot and test results to the PR description. Could a maintainer approve the pending CI workflows and manually link #50153? The description includes Thank you! |
|
Independent verification on the packaged Windows build (Desktop 2.0.12, Windows 11 10.0.26200), for the "no packaged build has been verified" note above. Method: instrumented the shipped renderer's IPC port (MessagePort) and replayed requests through the real RPC transport.
and the decode failure no longer occurs (no Scope note for reviewers: in the shipped bundle the request boundary ( Caveat: this is packaged-binary verification (normalized the request boundary in the installed renderer), not a build of this branch, and the native dialog itself was not visually confirmed in my remote session. |
|
Confirmed the same failure in OpenCode Desktop 2.0.12, Linux x64 AppImage on Omarchy/Hyprland, with Nautilus 50.3.1. Clicking Open in File Manager consistently shows “Desktop IPC handler failed,” including after restarting the desktop. Captured the underlying RPC failure through the renderer debugger: The renderer sends No configured plugins. The installed AppImage was tested; this PR’s build has not been tested locally. |
|
Thanks @ilajosmanov and @Vibe-coding-nvm-delete-repo for the independent confirmations on Linux and the packaged Windows build. These findings match the regression cases already covered by this PR, including |
|
Confirmed this still reproduces on OpenCode Desktop 2.0.13 on Windows. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #50153
Type of change
What does this PR do?
Opening “Images and files” sends
title: undefinedover the desktop MessagePort. The server's JSON codec rejects it before the picker handler runs, producingDesktop IPC handler failed.Omit undefined fields from plain objects at the renderer's request boundary, including nested options. Preserve non-plain objects, including attachment byte arrays, rather than converting them to plain objects. Add regression coverage through the real RPC transport for the picker, directory/save dialogs, opening paths and binary uploads.
This addresses request decoding; #50207 separately improves error reporting.
How did you verify your code works?
Against
v2.0.11, the original payload reproducedExpected string | null at ["options"]["title"]. On the updatedv2base:packages/desktop:bun test src/main/ipc-transport.test.ts src/renderer/ipc-payload.test.ts src/renderer/platform/files.test.ts src/main/files— 35 passed.packages/desktop:bun typecheck— passed.Manually verified on Windows using the native Electron development app at commit
fb189dc599:No prompt was submitted. The desktop main/preload/renderer were built from this PR, with the installed 2.0.11 CLI used as the local backend.
The repository-wide
bun run checkcould not run because the filtered workspace install lacks the rootoxlintcommand; the scoped lint above used Oxlint 1.60.0 separately. No packaged build has been verified.I am using a tool to translate Japanese into English, so I apologize if the meaning is incorrect.
Screenshots / recordings
Windows development app after attaching the test PNG (white thumbnail) and TXT file:
Checklist