Repository navigation
chore(desktop): upgrade Electron to 44.4.3 - #50327
Merged
Merged
Conversation
Migrates the clipboard module to the Electron 44 ClipboardItem API, bumps electron-context-menu to its Electron 44 release, moves the console-message listener off the deprecated positional arguments, and repairs the devex startup benchmark milestones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron
42.10.1→44.4.3(Chromium 148 → 152, Node 24.19 → 24.21). 42 leaves the supported window when 45 ships.Breaking changes that applied
clipboardrearchitected:readImage/writeImageremoved, everything async,ClipboardItemmain/files/index.tsmigrated (below)electron-context-menureads the clipboard internally4.1.2→5.0.0("Require Electron 44")console-messagepositional args deprecatedwindows/recovery.tsuses the event object~/DownloadswithoutdefaultPathclipboard, ANGLE staticBenchmarks
bench:devex— coldbun dev:desktopto Home, fresh profile (Windows x64). Running it surfaced a dormant fresh-database bootstrap race in core, split out as #50344; the 42 baseline completed 3 runs before that race killed run 4, and the 44 column was measured with #50344 applied (5/5). The dominant phase is the source CLI booting under Bun and drifts between sessions;electronStartupis the Electron-attributable phase.app starting)The bench itself was stale (
loading task finished,awaiting server ready,server readyno longer log); milestones now tracklayers readyand the current window-before-service order.bench:startup— packaged builds, same bundled CLI, alternating launches, warm service, 5 runs.Windows x64 package
libEGL.dll+libGLESv2.dllNotes
[email protected]still uses positionalconsole-messageargs inspyRendererConsole(upstream); args are deprecated, not removed.test/browser-native.test.tsfails onv2independently:browser.preview(feat(app): open agent-referenced files as rich artifact tabs #49882) is not exercised by the operation-coverage assertion.Buffer/setImmediate/require("events"); syncsafeStoragedeprecated;display-capturepermission split frommedia.