Repository navigation
Conversation
Databases migrated from V1 keep the legacy session/message/part/todo store alongside session_v2, but the Deleted projection only removed the V2 row, orphaning the legacy copy forever. Guard a legacy delete on a schema lookup so fresh and renamed-lineage databases skip it, and let the legacy foreign keys cascade the child rows.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50260
Type of change
What does the PR do?
Session.removepublishesSessionEvent.Deleted, which the projector in packages/core/src/session/projector.ts uses to delete the session row fromsession_v2. However the V1→V2 migration path copies legacy rows into the V2 tables but never drops the legacy tables. When a session is removed, only the V2 row is deleted — the legacy rows (session, message, part, todo) remain orphaned.The fix extends the
SessionEvent.Deletedprojection to also delete legacy rows when the legacysessiontable exists, probingsqlite_masterat runtime so it is safe for fresh V2-only databases.How did you verify your code works?
Added
test/session-remove.test.tscreating legacy rows alongside a V2 session, callingSession.remove, and asserting all 4 legacy tables are empty.bun test test/sessionis 612 pass / 0 fail.bun run typecheckclean.bun run check0 errors.Screenshots / recordings
Not a UI change.
Checklist