Repository navigation
fix(plugin): forward Promise tool cancellation - #50190
Merged
Merged
Conversation
4 of 6 tasks
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A
Type of change
What does this PR do?
Promise-style plugin tools previously lost the AbortSignal created by the Effect runtime, so stopping a session interrupted Core while the underlying tool operation kept running. This forwards that signal through the Promise ToolContext and uses it for adapted progress and Effect-backed executors. It also documents the signal and adds an integration test covering interruption.
How did you verify your code works?
bun test test/plugin/promise-tool.test.tsfrompackages/corebun run checkbun run check:generatedfromservices/wwwbun run buildfromservices/wwwScreenshots / recordings
N/A — no UI changes.
Checklist