Repository navigation
feat(copilot): send Copilot-Integration-Id header (#50105) - #50116
Closed
MarkMielke wants to merge 1 commit into
Closed
MarkMielke wants to merge 1 commit into
MarkMielke wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50105
Type of change
What does this PR do?
Without Copilot-Integration-Id, certain Github Copilot features are masked. In the specific case being addressed, the Enterprise BYOK feature allows custom models to be added that show up in VS Code, but they do not show up in OpenCode. After some head-scratching moments including direct testing with curl, I realized that it only works when Copilot-Integration-Id is filled in. I then found that OpenCode had previously used this header, but the header got lost in a refactor.
Originally I reported that adding just one line seems to work - and it does, however, it isn't clear why it works for both /models and /chat/completions, so I am also changing the place that should cover /chat/completions to make it explicit.
How did you verify your code works?
Tested manually, also added test cases to prevent future regressions.
Checklist