Skip to content

fix(core): resolve npm for Git plugin preparation - #49795

Closed
opencode-agent[bot] wants to merge 1 commit into
devfrom
plugin-git-49785
Closed

opencode-agent[bot] wants to merge 1 commit into
devfrom
plugin-git-49785

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • discard the synthetic npmBin produced by @npmcli/config for OpenCode's util package
  • let Pacote resolve the real npm executable from PATH when preparing Git dependencies
  • cover Git packages with prepare scripts through the public Npm.add interface

Addresses #49785.

Testing

  • PATH="/tmp/opencode/issue-49785-bin:$PATH" bun test test/npm.test.ts test/npm-config.test.ts (22 passed)
  • bun typecheck in packages/core
  • bun typecheck in packages/util
  • exact reported Git spec installs successfully through Npm.add
  • bun run check lint passed; repository-wide typecheck is blocked by the host's Node 18.19.1 while Astro requires Node >=22.12.0

Requested by: @rekram1-node (Aiden Cline via Slack)

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant