Repository navigation
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49635
Type of change
What does this PR do?
Typing or dictating a large amount of text into the TUI chat input made it lag badly as the buffer grew, because
mentionTriggerIndexruns on every keystroke (onContentChange→ autocompleteonInput) and was doing two full-bufferIntl.Segmenterpasses per keystroke — measured ~65ms at 100KB of input.The fix adds two cheap raw-string gates so the display-aware scan only runs when an actual
@trigger needs resolving:@in the buffer → return immediately (~0.001ms)Non-ASCII text, mid-buffer cursors and active
@mentions still take the exact original code path, so behavior is unchanged. A randomized parity test (~500 cases) additionally proves the new fast paths return identical results to the old implementation.How did you verify your code works?
bun testinpackages/tui: 202 pass, 0 fail (includes the newtest/util/display.test.ts)tsgo --noEmit: cleanoxlint: 0 errorsScreenshots / recordings
N/A – no visual change.
Checklist