Repository navigation
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
The test, typecheck and nix-eval workflow runs are waiting for maintainer approval (action_required). Local app gates and the repository pre-push typecheck passed. Could a maintainer approve the fork workflow runs when reviewing? |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49518. Related to #41412.
Type of change
What does this PR do?
Evict rejected directory reads from the picker cache so typing again can recover without reopening the dialog. Successful reads stay cached.
How did you verify your code works?
On Linux: regression fails before the fix and passes after. Tests cover recovery, caching, spaces/Unicode, and an older rejected request completing after a newer search.
App: 726 unit tests, 41 browser-condition tests, typecheck and production build pass. Pre-push: all 30 typecheck tasks pass. Focused lint: 0 errors, 15 warnings. Formatting and diff checks pass.
Screenshots / recordings
No layout changes; this corrects asynchronous cache recovery. Regression evidence is in directory-picker-domain.test.ts.
Checklist