Repository navigation
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42172
Type of change
What does this PR do?
The session picker renders its ctrl+a hint on the right side of the shared DialogSelect footer. The footer used 4 columns of left padding but only 2 on the right, causing the hint to extend past the dialog header alignment.
This makes the footer padding symmetric and adds a regression test that verifies the right footer hint ends at the same column as the header esc action.
How did you verify your code works?
packages/tui/test/cli/tui/dialog-select.test.tsx: 33 passed, 0 failedpackages/tuisuite: 1340 tests passed; two unrelated PTY tests hit the existing 5s timeout on macOSScreenshots / recordings
Before
After
Checklist