Repository navigation
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #49449
Follow-up to #26449.
Type of change
What does this PR do?
When the interactive login-shell environment probe exceeds its five-second timeout, Desktop currently falls back directly to the minimal app environment. That can drop Homebrew and user-local paths even though the cheaper login-only probe would succeed.
Retry with
-lafter an-iltimeout, matching the existing fallback for other probe failures. This keeps slow interactive startup files from causing intermittentcommand not founderrors.How did you verify your code works?
npx --yes [email protected] test src/main/shell-env.test.tsfrompackages/desktop(6 passed)PATH=/usr/bin:/bin:/usr/sbin:/sbin;zsh -lcresolved bothuvandffmpegzsh -lcat about 0.1 seconds versus 1.2-1.8 seconds forzsh -ilclocallytsgois not installedScreenshots / recordings
N/A - no UI changes.
Checklist