Repository navigation
Conversation
nexxeln
force-pushed
the
acp-command-lifecycle
branch
from
September 16, 2026 11:05
97769c4 to
5258487
Compare
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
|
The bug is still present ins 2.1.3. Please fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ACP treated every slash command as an immediate action:
session/promptreturnedend_turnas soon assession.commandacknowledged the request, so the model work started by/init,/review, MCP prompt commands, and config template commands was never streamed to the client.Change
messageIDand return an explicit outcome:{ type: "immediate" }(orvoid) when they finish inside the request, or{ type: "prompt", inboxID }when they admitted session input. Core rejects apromptoutcome whoseinboxIDdiffers from the invocationmessageID, since clients follow that ID.promptoutcome. Subagent commands report the child admission.session.commandaccepts an optionalidand returns the outcome. Client and OpenAPI regenerated.id, returns immediately only forimmediate, and otherwise keeps the prompt pending until the work completes, including child sessions spawned by subagent commands and the parent's follow-up run. Cancelling interrupts open children and any session that starts after the cancel.Tests
/init, immediate plugin commands (no model requests), subagent command, and cancellation during template and subagent work.