Skip to content

fix(acp): preserve slash command prompt lifecycle - #49208

Closed
nexxeln wants to merge 3 commits into
devfrom
acp-command-lifecycle
Closed

nexxeln wants to merge 3 commits into
devfrom
acp-command-lifecycle

Conversation

@nexxeln

@nexxeln nexxeln commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

ACP treated every slash command as an immediate action: session/prompt returned end_turn as soon as session.command acknowledged the request, so the model work started by /init, /review, MCP prompt commands, and config template commands was never streamed to the client.

Change

  • Commands receive a messageID and return an explicit outcome: { type: "immediate" } (or void) when they finish inside the request, or { type: "prompt", inboxID } when they admitted session input. Core rejects a prompt outcome whose inboxID differs from the invocation messageID, since clients follow that ID.
  • Built-in and config commands admit with the invocation ID and return the prompt outcome. Subagent commands report the child admission.
  • session.command accepts an optional id and returns the outcome. Client and OpenAPI regenerated.
  • ACP passes its turn start ID as the command id, returns immediately only for immediate, and otherwise keeps the prompt pending until the work completes, including child sessions spawned by subagent commands and the parent's follow-up run. Cancelling interrupts open children and any session that starts after the cancel.

Tests

  • New subprocess tests with a gated model: template command, /init, immediate plugin commands (no model requests), subagent command, and cancellation during template and subagent work.
  • In-process tests for pending-until-complete, child-session outcomes, and cancellation ordering; core tests for outcome validation.
  • ACP suite 94 → 103 passing.

@nexxeln
nexxeln force-pushed the acp-command-lifecycle branch from 97769c4 to 5258487 Compare September 16, 2026 11:05
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@iradraconis

Copy link
Copy Markdown

The bug is still present ins 2.1.3. Please fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants