Repository navigation
fix(app): restore queued attachments to the composer when editing - #49081
Merged
Merged
Conversation
Hona
force-pushed
the
queue-edit-attachments
branch
from
September 15, 2026 00:36
6d36c77 to
c28dd4c
Compare
Hona
enabled auto-merge (squash)
September 15, 2026 00:43
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a queued follow-up to edit it only restored the text. Its attachments stayed hidden in the inbox payload and were silently re-attached on confirm, so they could not be seen, removed, or extended. An attachment-only entry opened an empty composer and confirming it just cancelled the edit.
flowchart LR subgraph edit A[inbox payload.files] -->|inline, no mention| B[composer image parts] A -->|mention or file:// context| C[kept in payload] end subgraph confirm B --> D[request.files] C --> D D --> E[replacement prompt] endedit()hydrates inline attachments intoImageAttachmentParts viacreateLegacyBlobReference, the same shapeextractPromptFromMessageuses for delivered messages, so the composer chips render with their remove buttons.editedPromptInput()now takes attachments from the composer and only carries over stored file mentions andfile://context files, which the composer cannot represent.