Repository navigation
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
2 of 6 tasks
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A — found while running desktop dev on Hebrew Windows (no existing issue).
Type of change
What does this PR do?
On Hebrew/Arabic Windows the native caption buttons (minimize/maximize/close) sit on the left side of the window, but the desktop titlebar always reserved space on the right (
margin-right: auto) and never switched to RTL, so the header overlapped the caption controls.Changes:
systemPrefersRtl()inpackages/app/src/i18n/desktop-native.tsdetects RTL OS languages fromnavigator.languages(which is the OS language in Electron), including Hebrew (heplus legacyiw). Hebrew has no UI bundle, so it keeps English strings but now gets RTL chrome.language.systemDirection()in the language context, consumed only by the titlebar:<header dir>plusmargin-left: autounder RTL system languages /margin-right: autounder LTR ones. Document direction and conversation content still follow the UI locale — only the header follows the OS language, because only the native window chrome depends on it.direction.togglecommand (mod+shift+d, View category) that flips the content direction, same as the debug-bar DIR switch.command.direction.togglewas added with English fallback text in the locale files; real translations should go throughtranslate:app.The second commit (
fix: restore triple-slash references in custom-elements) is a prerequisite, not an unrelated feature:bun typecheckfails identically on cleandevwithout it, so no green CI is possible without it. Happy to split it into its own PR on request.How did you verify your code works?
bun test src/i18n/desktop-native.test.ts(newsystemPrefersRtlcases:he-IL,iw-IL,ar-EG, LTR negatives, tag normalization) plus the command/layout suites: 27 pass, 0 fail.bun typecheck: 30/30 successful.electron-vite devon Hebrew Windows and watched the header mirror withmargin-left: auto; toggled content direction with the new hotkey.Screenshots / recordings
Checklist