Repository navigation
Conversation
On Windows ConPTY stacks (Alacritty + zellij) exiting opencode terminated the shell/zellij pane that launched it, for two reasons: - @OpenTui's native lib.destroyRenderer teardown closes the shared console. Skip it on win32; the OS releases the native handle when the process exits. - Emitting \x1b[?1049l to leave the alternate screen races with process teardown and is fatal there. On win32 clear the screen with \x1b[2J\x1b[H instead; other platforms keep leaving the alternate screen. Also write the reset synchronously (fs.writeSync) so it is delivered before exit.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48782 (that PR cannot be reopened).
Problem
On Windows, exiting opencode inside a ConPTY stack (Alacritty + zellij) terminated the pane/shell that launched opencode instead of returning to the prompt. Reproduced with both the patched and the official binary, and also with
cmd.exe/pwsh.exeas the parent shell.Cause
Two things in the @OpenTui renderer teardown on Windows ConPTY:
lib.destroyRenderercloses the shared console, which terminates the parent shell.\x1b[?1049l(leave alternate screen) races with process teardown and is fatal there.Fix
lib.destroyRenderercall onwin32(the OS releases the native handle when the process exits).win32, do not emit\x1b[?1049l; clear the screen with\x1b[2J\x1b[Hinstead. Other platforms keep leaving the alternate screen.fs.writeSync) so it is delivered before exit.Fixes #48776.