Skip to content

fix(tui): truncate generic tool summaries to the available width - #48807

Closed
fihaaade wants to merge 2 commits into
anomalyco:devfrom
fihaaade:truncate-tool-summary
Closed

fihaaade wants to merge 2 commits into
anomalyco:devfrom
fihaaade:truncate-tool-summary

Conversation

@fihaaade

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #48783

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Long plugin and MCP tool inputs currently wrap across many lines even when the tool is collapsed. Truncate the summary to the available terminal columns, accounting for the row padding and icon. Reuse Locale.truncateWidth to preserve whole graphemes and add an ellipsis. Expanded details retain the full input.

How did you verify your code works?

  • 30 related tests pass, including OpenTUI rendering at 36, 72, and 120 columns with a 5,000-character input, plus Unicode and argument-formatting cases.
  • The five new regression cases fail on the unmodified base.
  • Native macOS arm64 CLI build succeeds.
  • bun typecheck reports the same six Node typing errors on both the unmodified base and this patch.

Screenshots / recordings

pr.-.Compressed.with.FlexClip.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@fihaaade

Copy link
Copy Markdown
Contributor Author

The PR description already includes Closes #48783. This PR targets v2, so GitHub returns no closingIssuesReferences because it only populates them for the default branch (dev). The v2 workflow already has a body-reference fallback, but this run used the older check. Could a maintainer help resolve the needs:issue label?

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: V2 TUI generic tool summary prints full tool input on the collapsed line (untruncated)

1 participant