Skip to content

Feat/tui i18n - #48731

Closed
neriousy wants to merge 6 commits into
devfrom
feat/tui-i18n
Closed

neriousy wants to merge 6 commits into
devfrom
feat/tui-i18n

Conversation

@neriousy

Copy link
Copy Markdown
Member

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

Filip Hejmowski added 2 commits September 13, 2026 00:25
@neriousy
neriousy marked this pull request as ready for review September 14, 2026 13:58
@imyu37

imyu37 commented Sep 23, 2026

Copy link
Copy Markdown

This is a solid piece of work — lazy-loaded per-locale dictionaries, t()/plural via Intl.PluralRules, the language picker, config.language, and green CI on the branch. Exactly the shape I'd want TUI i18n to take, and it saves rebuilding it from scratch.

Two things stand out as risks though: the branch is ~309 commits behind v2 (currently mergeable: dirty), and the PR body is still the empty template — compliance bots close uncorrected PRs after 2 hours, and there's a 1-month stale-PR cleanup too.

Would you like a hand getting this over the line? I can help with:

  • rebasing onto current v2
  • proofreading zh/zht (e.g. tui.session.delete and command.prompt.mode.normal look untranslated; zht.ts also has an extra tui.askAnythingExample key that doesn't exist in en.ts)
  • filling in the PR template so it survives the compliance check

Happy to review/test rather than push commits if you prefer to drive. And if you'd rather I take over via a fork (keeping your authorship credited), just say so — otherwise I'll assume you've got it and step back.

@imyu37

imyu37 commented Sep 29, 2026

Copy link
Copy Markdown

Update: this PR has been idle for ~6 days and v2 has moved ~550 commits ahead, so I've taken the liberty of carrying the work forward — the branch has been merged onto current v2 (conflicts resolved against the evolved theme/dialog/diff-viewer APIs) and resubmitted as #52000.

Your original commits are preserved via a merge commit, so authorship stays intact. You're very welcome to review #52000, request changes, or keep building on it — happy to hand control back if you'd rather continue yourself.

@thdxr
thdxr changed the base branch from v2 to dev October 10, 2026 19:07
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants