Repository navigation
fix(tui): include reasoning tokens in throughput - #48689
Merged
rekram1-node merged 2 commits intoSep 18, 2026
Merged
rekram1-node merged 2 commits into
rekram1-node merged 2 commits into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found:
All other searches returned only the current PR #48689, indicating no other duplicate PRs are present. |
Contributor
Author
|
@rekram1-node what do you think about accepting this PR? It fixes the same issue as #47125 and also includes reasoning tokens in the numerator for opencode v2. |
dukebw
force-pushed
the
dukebw/stack/0681e582ab9d4b2ab73deedf3a7b43a8
branch
from
September 17, 2026 12:59
7a47c3e to
2465b84
Compare
# What/why Session usage stores visible output and reasoning tokens separately. Counting only visible output understates the generated-token throughput in assistant footers. # How Sum output and reasoning tokens across assistant steps using upstream's existing request-duration calculation. Update the setting description and retain regression coverage for cross-model aggregation, missing stream boundaries, provider wait, tool settlement, retries, and durable replay. # Testing - Core session-runner tests. - TUI session-row tests and rendered footer lifecycle regression. - Full bun run check, generated-client consistency, and formatting checks. stack-pr-branch: dukebw/stack/0681e582ab9d4b2ab73deedf3a7b43a8
dukebw
force-pushed
the
dukebw/stack/0681e582ab9d4b2ab73deedf3a7b43a8
branch
from
September 17, 2026 15:04
2465b84 to
0df0c3b
Compare
dukebw
changed the title
Updated description for 'tps' to clarify its meaning.
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Co-authored-by: Aiden Cline <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48705
Type of change
What does this PR do?
Include reasoning tokens in the existing tok/s indicator. Session usage stores visible output and reasoning separately, so the throughput numerator now sums both across assistant steps.
For example, 80 reasoning tokens and 20 visible output tokens over a 3-second request produce 33.3 tok/s instead of 6.7 tok/s.
Update the setting description and retain regression coverage for cross-model aggregation, missing stream boundaries, provider wait, tool settlement, retries, and durable replay.
How did you verify your code works?
bun run checkpassed (lint and repository-wide typechecks).Screenshots / recordings
The existing footer layout is unchanged; this corrects the value it displays.
Checklist