Repository navigation
Conversation
bun install succeeds on FreeBSD since Bun only skips platform-mismatched optional dependencies instead of failing, but @ff-labs/fff-bun declares os/cpu fields without a FreeBSD entry so the package is never extracted. The static import then crashed startup, so resolve the binding through a guarded top-level dynamic import and degrade to the existing ripgrep fallback when it is missing. Also add @parcel/watcher-freebsd-x64 to the pinned watcher bindings and reserve minimumReleaseAge excludes for future FreeBSD native packages.
Mawfyy
marked this pull request as draft
September 12, 2026 13:30
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Mawfyy
marked this pull request as ready for review
September 12, 2026 13:40
Mawfyy
marked this pull request as draft
September 12, 2026 13:40
Mawfyy
marked this pull request as ready for review
September 13, 2026 03:09
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48658
Type of change
What does this PR do?
On FreeBSD,
bun installsucceeds but skips@ff-labs/fff-bun(itsosfield has no freebsd entry), so the static import infff.bun.tscrashes the CLI at startup.This replaces the static import with a guarded top-level dynamic import. When the package is missing,
Fff.available()returns false andFff.create()returns an error result, so the existing ripgrep fallback insearch.tshandles search and the CLI boots normally. Behavior is unchanged on platforms where the package exists.Also pins
@parcel/[email protected]alongside the other watcher platform bindings (needed for standalone builds withbun install --os="*" --cpu="*"), and reservesminimumReleaseAgeExcludesentries for future FreeBSD native packages.How did you verify your code works?
bun run --cwd packages/opencode ./src/index.ts --versionexits 0,Fff.available()is false, ripgrep fallback engagesFff.available()is true,Fff.create()succeeds — no behavior changebun install --os=freebsd --cpu=x64completesbun run typecheckpasses in packages/core and packages/opencode; fullbun testin packages/core: 1098 pass, 0 failNot yet tested on a real FreeBSD host; TUI (
@opentui/core) and PTY (bun-pty) still lack FreeBSD binaries — those are separate issues.Screenshots / recordings
Not a UI change.
Checklist