Repository navigation
Conversation
This was referenced Sep 12, 2026
Closed
3 of 6 tasks
Author
|
Closing in favor of #51084, which supersedes this PR and implements the fix and regression coverage for the v2 architecture. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #33137
Fixes #46396
Addresses the streaming-content half of #41408; its animated-number issue remains separate.
Type of change
What does this PR do?
Active assistant output was wrapped in
aria-hidden, so visible streamed text, reasoning, and tool activity disappeared from the accessibility tree until the turn ended.This removes that attribute from the current app timeline and adds a Playwright ARIA-snapshot regression test for an incomplete assistant response. It deliberately leaves
aria-live="off"unchanged so browsing the stream does not also announce every token.Prior work: @ashu-choudhury identified the root cause and proposed removing the attribute in #33139. @abdullahsaad27 traced the active Desktop renderer and explored the
aria-busy/live-region alternative in #38393. This PR applies the narrower fix to currentdevand adds regression coverage.How did you verify your code works?
bun turbo typecheck(30 packages via the pre-push hook)Screenshots / recordings
N/A — this changes only the accessibility tree. The regression snapshot changes from empty to
paragraph: Streaming assistant output; visual rendering is unchanged.Checklist