Repository navigation
fix(app): decouple MCP resource refresh from toggle - #48391
Closed
mapix-etnc wants to merge 1 commit into
Closed
mapix-etnc wants to merge 1 commit into
mapix-etnc wants to merge 1 commit into
Conversation
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #48386
Type of change
What does this PR do?
After an MCP toggle connects, the Desktop UI now awaits only the MCP status refresh. Resource catalog discovery runs as a non-blocking best-effort refresh, so a slow or unsupported
resources/listfrom any connected server cannot block the toggle or make it appear to fail. Resource refresh rejections are caught so they do not become unhandled rejections.The regression tests cover the three toggle actions, pending connections, non-blocking resource discovery, and a rejected
refreshResources()call.How did you verify your code works?
cd packages/app && bun test --conditions=solid --preload ./happydom.ts ./src/context/global-sync/mcp.test.tsbun --cwd packages/app typecheckbunx prettier --check packages/app/src/context/global-sync/mcp.ts packages/app/src/context/global-sync/mcp.test.ts packages/app/src/context/server-sync.tsxbun turbo typecheckScreenshots / recordings
Not applicable; this is a behavior-only fix with no UI changes.
Checklist
If you do not follow this template your PR will be automatically rejected.