Skip to content

fix(desktop): report default file opener errors - #47891

Closed
fancive wants to merge 1 commit into
anomalyco:devfrom
fancive:openpath-errors
Closed

fancive wants to merge 1 commit into
anomalyco:devfrom
fancive:openpath-errors

Conversation

@fancive

@fancive fancive commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #47722

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Reject non-empty errors returned by Electron's shell.openPath so the existing UI error handler reports failed opens. Successful opens and explicitly selected applications keep their existing behavior.

How did you verify your code works?

  • Focused regression tests: 3 passed; the failure case failed before the fix.
  • Desktop typecheck and formatting passed. Oxlint reported only two warnings also present on the original code.
  • macOS, Electron 42.3.3: real native IPC resolved an error string before the fix and rejected it afterward. Explicit-app failures still reject.
  • Desktop suite: 74 passed; draft-store is blocked because Bun 1.3.14 lacks node:sqlite.

Screenshots / recordings

Not captured. Full desktop UI interaction was not manually exercised.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Found a related PR:

#47724: fix(desktop): surface default path opening errors

This appears to be addressing the same issue (#47722) as the current PR (#47891). Both are fixing error reporting for default file opener functionality in the desktop app. You may want to check if #47724 is still open and whether the current PR duplicates or builds on that work.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop silently ignores failures when opening the default file manager

1 participant