Repository navigation
Conversation
Auto mode lived in the client, so the server published permission.asked before anything auto-approved it. Integrations such as Warp and Orca saw attention requests that nobody had to answer (opencode#47545). Move auto approval into the Permission service as an ephemeral, owner-scoped lease. A request covered by a live lease is resolved during evaluation, so neither permission.asked nor permission.replied is published for it, and permission.asked keeps meaning a human has to respond. - explicit deny rules are evaluated first and still win - auto is not a permission rule - acquiring a lease never touches requests that were already pending - a lease expires unless its owner renews it, so a crashed or killed client cannot leave a shared server in auto mode - the TUI takes an instance scoped lease, matching what it does today - opencode run --auto takes a session scoped lease covering only that run's session and its subagents, so run --attach --auto leaves other sessions alone - clients keep their old client-side auto reply against servers without the lease endpoint
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47545
Type of change
What does this PR do?
Moves Auto permission handling server-side so auto-approved requests are resolved before
permission.askedis emitted.Auto is represented as a renewable client lease. Deny rules still take precedence, and leases expire if the client disappears.
TUI Auto applies to all sessions on the connected server, matching its current behavior.
run --autoonly applies to that run and its child sessions.This PR is draft mainly to confirm whether TUI Auto should continue applying to all sessions, or only the current session.
How did you verify your code works?
Added tests for lease behavior, Auto scope, deny precedence, and
permission.askedsuppression.bun typecheckpasses.Screenshots / recordings
Not a UI change.
Checklist