Repository navigation
feat(desktop): add SSH server connections - #47753
Merged
Merged
Conversation
Brendonovich
marked this pull request as ready for review
September 8, 2026 06:36
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH connection form
New SSH dialog, captured from the committed branch's Storybook fixture at 800 × 500.
Recording
Password → verification code → connected, with a five-second fixture delay after each response. Inputs stay visible and disabled until the next prompt arrives. Recorded from
app-dialog-ssh--slow-passwordat 800 × 500 (12.4 seconds).ssh-password-flow.webm
Inactive session and reconnect
Reconnect → inline connecting state → password and verification challenge → connected. Captured from
app-dialog-ssh--inactive-sessionat 800 × 500 (11.3 seconds). This is a new SSH surface with no corresponding base-branch screen.ssh-reconnect-final.webm
Review fixes
Cancel a version-mismatch dialog, reconnect successfully to the dialog again, and cancel again. Recorded from
app-dialog-ssh--incompatible-sessionat 800 × 500 (5.6 seconds).ssh-retry-fixed.webm
Validation
v2: 961 app tests passed; desktop CI-mode suite passed (158 tests, 2 platform/display skips).Native Windows/WSL and packaged-app testing remain review follow-ups for this draft. The new upstream display-dependent browser suite failed locally at
browser.hoverwithUnknownVizError; that suite is already excluded from CI by its existing display guard.