Repository navigation
fix(desktop): surface default path opening errors - #47724
Closed
Woolgathererer wants to merge 1 commit into
Closed
Woolgathererer wants to merge 1 commit into
Woolgathererer wants to merge 1 commit into
Conversation
3 of 6 tasks
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47722
Type of change
What does this PR do?
Reject non-empty errors returned by Electron's
shell.openPath()so a failed file-manager launch reaches the existing request-error toast. Extract the IPC operation into a testable function; explicit application launching keeps its existing behavior.How did you verify your code works?
bun test src/main/open-path.test.ts: 3 passing tests for success, resolved error strings, and rejected errors. The error-string regression failed before the fix.bun typecheckinpackages/desktop: passes.git diff --check: pass.Screenshots / recordings
Not captured. This changes IPC error propagation and reuses the existing toast. Full desktop UI verification has not been performed.
Checklist