Skip to content

feat: add skill activation settings - #47595

Closed
neriousy wants to merge 9 commits into
v2from
feat/skills-disable-enable
Closed

feat: add skill activation settings#47595
neriousy wants to merge 9 commits into
v2from
feat/skills-disable-enable

Conversation

@neriousy

@neriousy neriousy commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Issue for this PR

Related: #43536

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds persistent, server-wide skill enable/disable settings.

  • Adds skill toggles to the TUI and desktop/web settings.
  • Filters disabled skills from skill pickers, composer mentions, and model guidance.
  • Rejects new tool loads, prompt attachments, and explicit activation for disabled skills while preserving existing history.
  • Adds a reusable settings service and API:
    • GET /api/settings
    • GET /api/settings/:kind/:id
    • PUT /api/settings/:kind/:id
    • DELETE /api/settings/:kind/:id
  • Exposes Settings, settings.updated, client.settings, and SettingsApi across the schema, core, protocol, and generated clients.

skill.activation is the first setting kind and accepts enabled or disabled. Skills remain enabled by default, and reset removes the explicit override. This follows V2 skill invocation and does not restore legacy slash-command support.

How did you verify your code works?

  • bun run check
  • Focused Core, Server, ACP, TUI, and Mini tests
  • Protocol and website generated-file checks
  • Regenerated Promise/Effect clients and OpenAPI documents

Screenshots / recordings

Not attached. Renderer and browser tests cover the toggle interactions.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@neriousy neriousy changed the title feat: disable / enable skills + preferences api feat: add skill activation settings Sep 14, 2026
@neriousy
neriousy marked this pull request as draft September 14, 2026 15:21
@github-actions github-actions Bot mentioned this pull request Sep 15, 2026
Closed
3 of 6 tasks
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hona Hona Awaiting requested review from Hona Hona will be requested when the pull request is marked ready for review Hona is a code owner
@Brendonovich Brendonovich Awaiting requested review from Brendonovich Brendonovich will be requested when the pull request is marked ready for review Brendonovich is a code owner

Assignees

No one assigned

Labels

automated-pr-cleanup contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@neriousy