Repository navigation
fix(app): let long model, agent and variant names truncate in the composer footer - #47330
Capicua25x wants to merge 2 commits into
Conversation
…he composer footer The composer footer is a flex row (+ / agent / model / variant / send). Each control's label is a 'truncate' span inside an inline-flex ButtonV2, and the button sits inside a TooltipV2 trigger div (display: flex). A flex item defaults to min-width: auto, so at every level of that chain the box refuses to shrink below its content and 'truncate' never gets a chance: with a long model display name on a narrow viewport the row overflows and the variant control ends up under the send button. Fix: min-w-0 on the label spans, on the shared agent/variant trigger button (it had max-w without min-w), and on the TooltipV2 trigger wrapper of both the model control and the configured selects, so the ellipsis can kick in. No change on wide viewports.
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, I found one related PR that may be addressing a similar issue: Related PR found:
This PR appears to be related to the same problem area (controls covering the send button in the composer footer), though it may have been closed or superseded by the current PR #47330. Additionally, PR #43298 ( These PRs share the same root cause domain (composer footer overflow issues on narrow displays), but the current PR (#47330) is the one that specifically addresses the truncation fix. |
…omalyco#43295) Mocks a model with a long display name and a variant, opens a session at 320 px and asserts that the controls row, the model button and the variant chip all end before the send button starts, and that the send button stays inside the viewport. Adds a data-slot="prompt-controls" anchor on the controls row. The idea of asserting the send button's box against the controls' box at 320 px comes from bmpenuelas' anomalyco#43298; this is a fresh spec written for the truncation approach.
|
Added a regression test ( |
|
Kevin Costner
Official for Kevin Costner
🎬 @horizonamericansaga
🎻 @modernwestband
**Yes, this is the real me.**
…On Fri, Sep 4, 2026, 9:06 PM Capicua25x ***@***.***> wrote:
Closed #47330 <#47330>.
—
Reply to this email directly, view it on GitHub
<#47330?email_source=notifications&email_token=CMSNYI4RBDINQ6UK4S4NXAT5NMOFDA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBVG44DQNRSGA2DJJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-30578862044>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CMSNYI3SQCOS2KS2Z2QBBBD5NMOFDAVCNFSNUABFKJSXA33TNF2G64TZHM4TONJXGM2DGMJZHNEXG43VMU5TKMZVGA2DSMZSGY32C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Issue for this PR
Closes #43295
Type of change
What does this PR do?
On a phone the V2 composer footer (agent / model / variant) runs under the send button when the model has a longer display name: the row is a flex row, and none of the controls can get narrower than their text, so the last one is pushed under the button.
Every control already renders its label in a
truncatespan, but that span sits inside an inline-flex button, which sits inside the TooltipV2 trigger div (display: flex). Flex items default tomin-width: auto, so at each of those three levels the box refuses to shrink below its content andtruncatenever gets to act.The change is
min-w-0at those levels: the label spans, the shared agent/variant trigger button (it hadmax-w-[220px]without amin-w), and the tooltip trigger wrapper around the model control and the configured selects. With that the labels ellipsize instead of overflowing, and nothing changes on wide viewports. 3 files, +6/-4.How did you verify your code works?
dev(1.18.28) with the patch, ran it on an Android phone (~412 px): the variant control no longer sits under the send button; the model name ellipsizes first.getBoundingClientRectof the footer controls before/after: before, the variant control spanned x 303–385 (past the viewport, under the send button at x 291); after, Build 73–120, model 124–230, variant 234–291, send button 291–319.Screenshots / recordings
Phone, before / after:
Headless Chromium at 360 px, before / after:
Checklist