Repository navigation
refactor(app): remove redundant project setter wrappers - #47085
Merged
Merged
Conversation
kitlangton
enabled auto-merge (squash)
September 3, 2026 16:21
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Project writes pass through three wrappers (
setProjects,setBootStore, andset) that ultimately call the native Solid store setter without transforming the data. The wrappers add array/function checks and type assertions to operations the setter already supports.What Changes
Pass
setGlobalStoredirectly to bootstrap, use it directly for project updates, and retain the returned setter asset: setGlobalStore.Project-array replacement and functional updates retain their store behavior. The declared
SetStoreFunctioncontract returns void; the removed wrappers' incidental return values have no production consumers. No loading, refresh, or reconnect rules change.Scope
packages/app/src/runtime/server/sync.tsx: +3 / −23, net −20 production lines. No new production helper or dependency. The existing bootstrap test file gains coverage for a real client with a fixture transport, native-setter bootstrap, functional updates, empty-array replacement, and another bootstrap; test code is +49 / −1, net +48 lines.This is separate from the pending-inbox reconnect fix and the client location-spread cleanup. It changes no visible UI or session/timeline code.
Verification
With Bun 1.4.0, from
packages/app:bun run test bun run test:browser ./src/runtime/server/global-sync/bootstrap.test.ts bun typecheck bunx prettier --write src/runtime/server/sync.tsx src/runtime/server/global-sync/bootstrap.test.ts git diff --check