Repository navigation
fix(app): show review diffs for non-git VCS backends - #46684
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The project schema accepts any VCS backend, but normalizeProjectInfo rewrote everything except git to undefined and the review model gated its diff queries on `vcs === "git"`. Mercurial and plugin-registered backends therefore got the "create a Git repository" empty state even though the server returns their diffs through the VCS dispatcher. Drop the rewrite and gate on any backend instead. Co-Authored-By: Claude Opus 5 <[email protected]>
mayamika
force-pushed
the
plugin-vcs-review
branch
from
September 2, 2026 09:41
bc01497 to
a642855
Compare
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Co-authored-by: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #46472
Type of change
What does this PR do?
Makes the session review panel work for non-git VCS backends — Mercurial or any plugin-registered one.
normalizeProjectInforewrote every backend except git toundefined, and the review model gated its diff queries onvcs === "git", so the panel never left the empty state even though the server already returns those diffs. Dropped the rewrite and changed the five gates to check for any backend instead.How did you verify your code works?
normalizeProjectInfo.Screenshots / recordings
Before
After
Checklist