Repository navigation
fix(tui): rendering of colors in Markdown diff blocks - #46480
Closed
AndreasHolt wants to merge 1 commit into
Closed
AndreasHolt wants to merge 1 commit into
AndreasHolt wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Thanks for identifying and fixing this. We merged #46518, which incorporates the fix while pinning the highlighting query to the immutable upstream commit SHA. You are credited as a co-author there, so I’m closing this PR in favor of the merged version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46475
Type of change
What does this PR do?
Fixes missing colors in Markdown diff blocks.
Diff blocks appear without colors because OpenCode downloads highlighting rules that are too new for its diff parser. This change uses the rules from the same v0.1.0 release as the parser, which then fixes colors for added and removed lines as seen below.
This fix downloads the highlighting rules from the same v0.1.0 release as the parser
How did you verify your code works?
I reproduced the failure with the existing parser and query, then tested the v0.1.0 query with OpenTUI's Markdown renderer.
Screenshots
Checklist
If you do not follow this template your PR will be automatically rejected.