Repository navigation
feat(app): refine mobile diff review and wrapping preferences - #46390
Conversation
OpenCode-Session: ses_fa9929a54ffeG0AAK1g2BwuFHj OpenCode-Session: ses_fa96329bbffdPCp54xCdIn18M0 OpenCode-Session: ses_fa94e625fffdatsz7sy2hC4tMI OpenCode-Session: ses_fa93a9c41ffdv86XF9fhdYPok9 OpenCode-Session: ses_fa9375bf2ffd1qwP3qNWRyj1dW OpenCode-Session: ses_fa92bcf95ffefmn2bqtEY6z23J
OpenCode-Session: ses_fa9375bf2ffd1qwP3qNWRyj1dW OpenCode-Session: ses_fa8e8d9a1ffedn46jvXHQkVsgx OpenCode-Session: ses_fa8d40a0bffelgYWDAaU1XvYj8 OpenCode-Session: ses_fa8b885a0ffdKRQ0V2AMcGEu9a OpenCode-Session: ses_fa8c9b9c6ffeULe3oLIORr07X2 OpenCode-Session: ses_fa8b34988ffdpVySqqaO61cULj
OpenCode-Session: ses_fa8e8d9a1ffedn46jvXHQkVsgx OpenCode-Session: ses_fa8c9b9c6ffeULe3oLIORr07X2 OpenCode-Session: ses_fa8b1e744ffe1OzY51WvOANIwC OpenCode-Session: ses_fa8b34988ffdpVySqqaO61cULj
OpenCode-Session: ses_fa91badecffeXpbAgW57aYbHif
Add isolated fixture coverage for project selection, drawer navigation, and settings menu dismissal. The full-width settings assertion currently reproduces the committed mobile CSS load-order regression and requires the production selector fix before merge.
Fix the production CSS cascade discovered during screenshot verification and update legacy tab/sidebar regressions for the mobile drawer. OpenCode-Session: ses_fa91badecffeXpbAgW57aYbHif
OpenCode-Session: ses_fa91badecffeXpbAgW57aYbHif
OpenCode-Session: ses_fa91badecffeXpbAgW57aYbHif
|
Synced with current v2 in 628c32d using a merge (no history rewrite). Preserved the merged 16px mobile timeline/Usage spacing and top-only session view tabs, while retaining this PR’s full-width diff review, expanded change summaries, Open file behavior, and wrapping preference. Validation: 8 focused production-build mobile browser regressions, 4 virtualizer component tests, and all 620 app unit tests pass. Full pre-push workspace typecheck passes all 33 tasks with hooks enabled. The ACP permission-concurrency test responsible for both previous CI unit failures passes locally; fresh CI still needs to confirm Linux/Windows behavior. Production streaming benchmark completed in 1011ms before and 979ms after, with zero bottom drift or remounts (single local samples, not a statistical performance claim). The remaining diff against v2 is now limited to 13 mobile-review-related files. |
Summary
Stack
Merge in that order; each PR's diff and before/after evidence compare against its immediate base. Independent #46391 (touch controls/PWA) can land separately.
Sessions
ses_fa8e8d9a1ffedn46jvXHQkVsgx: diff summaries/layout, touch header states, immediate file selection.ses_fa8c9b9c6ffeULe3oLIORr07X2: summary Open file, mobile line numbers and wrapping.ses_fa8b1e744ffe1OzY51WvOANIwC: child of the preceding session; move Wrap lines to General preferences and update regression coverage.ses_fa8b34988ffdpVySqqaO61cULj: final Changes header divider.Before / After
Mobile review polish compared with its actual stacked panel base, plus desktop shared-component coverage.
Recording
Asserted screenshot milestone walkthrough, NOT a realtime recording: expand a mobile diff, enable/disable Wrap lines in corrected General preferences, pan horizontal code, then automatically select Files and checkout.ts. Light theme, 390x844, 12.04 seconds; no fabricated transitions.
review-flow-milestones-head.mp4
Validation
new-session-workspace-pending.spec.ts:38(diron HTMLElement | SVGElement); reproduced on clean v2.