Skip to content

fix: auto upgrade toast message #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rekram1-node merged 10 commits into from
Nov 22, 2025
Merged

fix: auto upgrade toast message #4625

rekram1-node merged 10 commits into from
Nov 22, 2025

Conversation

@Raviguntakala
Copy link
Contributor

@Raviguntakala Raviguntakala commented Nov 22, 2025 •
edited
Loading

Problem

  1. Upgrade toast notifications weren't showing because upgrade() was called in worker initialization before any clients connected to the event stream
  2. When auto-update is disabled, users weren't notified that updates are available

Solution

  1. Added checkUpgrade() RPC method to worker that calls upgrade() in proper Instance context
  2. TUI thread triggers checkUpgrade() via RPC after TUI starts, ensuring Instance is bootstrapped
  3. Added Installation.Event.UpdateAvailable to notify users when auto-update is disabled without auto-updating them
  4. Added toast notification handler in TUI to display manual update prompt when updates are available but auto-update is off

Testing

  • Verified auto-update complete toast notification appears when auto-update is enabled
  • Verified manual update available toast notification appears when auto-update is disabled
  • Both notifications display the correct version information

Files Changed

  • packages/opencode/src/cli/cmd/tui/worker.ts - Added checkUpgrade() RPC method with Instance.provide()
  • packages/opencode/src/cli/cmd/tui/thread.ts - Call checkUpgrade() RPC after TUI starts
  • packages/opencode/src/installation/index.ts - Added UpdateAvailable event definition
  • packages/opencode/src/cli/upgrade.ts - Modified to publish UpdateAvailable event when auto-update is disabled
  • packages/opencode/src/cli/cmd/tui/app.tsx - Added toast handler for UpdateAvailable event
  • packages/sdk/js/src/gen/types.gen.ts - Regenerated SDK types to include UpdateAvailable event

IMG_8329

Screenshot 2025-11-22 at 12 56 56 PM

@Raviguntakala
fix: move upgrade call from worker to event stream handler
722d169 
Move upgrade() from TUI worker initialization to /event endpoint handler.
The upgrade check now runs 1 second after a client connects to the event
stream, ensuring proper delivery of upgrade notifications.
@Raviguntakala Raviguntakala mentioned this pull request Nov 22, 2025
Closed
1 task
@rekram1-node
Copy link
Collaborator

rekram1-node commented Nov 22, 2025

To address that issue do you think we could update upgrade function to notify the user of an update if there is one but NOT auto update them (may need to create a new event for it)

rekram1-node
rekram1-node reviewed Nov 22, 2025
View reviewed changes
packages/opencode/src/server/server.ts Outdated
Comment on lines 1988 to 1989
setTimeout(() => {
upgrade()
Copy link
Collaborator

@rekram1-node rekram1-node Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this probably isn't the best spot for this tbh. The server is used in several types of environments (some people spawn these servers and connect multiple clients to it). Ideally we could have some setup w/ worker + tui thread so that once the tui is booted we run this

Copy link
Contributor Author

@Raviguntakala Raviguntakala Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use worker + TUI thread approach instead. Added checkUpgrade() RPC method to worker that's called from TUI thread after startup. This ensures it only runs once per TUI session and doesn't affect other server environments.

@Raviguntakala
Copy link
Contributor Author

Raviguntakala commented Nov 22, 2025

To address that issue do you think we could update upgrade function to notify the user of an update if there is one but NOT auto update them (may need to create a new event for it)

Yes, I've added Installation.Event.UpdateAvailable that publishes when auto-update is disabled. It notifies users of the available version and prompts them to run opencode upgrade manually.
Screenshot 2025-11-22 at 12 56 56 PM

@Raviguntakala
refactor: move upgrade check from server to worker RPC
3ef610d 
Call upgrade() via worker.checkUpgrade() RPC from TUI thread instead of in server /event endpoint. This ensures upgrade runs in proper Instance context and avoids running on every client connection.
@Raviguntakala
refactor: remove unnecessary comments in TUI and upgrade functions
89f4f74
@github-actions github-actions bot force-pushed the dev branch 2 times, most recently from df8bdf9 to 0dd5039 Compare November 22, 2025 18:21
@rekram1-node rekram1-node merged commit b92e851 into anomalyco:dev Nov 22, 2025
3 checks passed
rekram1-node pushed a commit that referenced this pull request Nov 23, 2025
@Raviguntakala @thdxr @rekram1-node
fix: auto upgrade toast message (#4625)
c8841b5 
Co-authored-by: Dax Raad <[email protected]>
Co-authored-by: opencode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rekram1-node rekram1-node Awaiting requested review from rekram1-node

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Raviguntakala @rekram1-node @thdxr