Repository navigation
Conversation
…pshot stores Failed or interrupted git gc runs leave tmp_pack_* files in objects/pack that are never removed: git only cleans them at the end of a successful gc and cleanup() returns early on failure. Remove repack temp files older than an hour after every gc run, success or failure. gc also fails permanently when the project's own gc prunes objects the snapshot store references through its alternates. Detect those failures and drop the store so the next track() rebuilds it from scratch instead of failing every hour and leaking disk forever.
This was referenced Aug 29, 2026
Closed
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46034
Type of change
What does this PR do?
The hourly snapshot cleanup runs
git gc --prune=7.days. When gc fails or is interrupted it leavestmp_pack_*files inobjects/pack/that are never removed: git only cleans them at the end of a successful gc, andcleanup()returned early on failure. This addspruneStale(), which removes repack temp files older than an hour after every gc run, success or failure.gc also fails permanently when the project's own
git gcprunes objects the snapshot store references through its alternates (seed()). The same missing object makes every hourly gc fail, leaking a new tmp_pack each time, forever. This PR detects those failures (unable to read/bad object/bad treein gc stderr) and drops the broken store so the nexttrack()rebuilds it from scratch.How did you verify your code works?
cleanup removes stale tmp pack files(stale files removed, recent ones and real packs kept) andcleanup rebuilds snapshot store when gc fails on missing objects(store dropped on missing-object gc failure, rebuilt by the next track). 57/57 tests pass, typecheck and oxlint clean.track(),git count-objectsreports zero garbage, and the hourly cleanup no longer fails.Screenshots / recordings
Not applicable – not a UI change.
Checklist