Repository navigation
fix(core): isolate shell jobs by shell ID - #45985
Merged
Merged
Conversation
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Co-authored-by: rekram1-node <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give each shell process its own job, keyed by its existing shell ID instead of the enclosing tool-call ID. Parallel shell calls inside one CodeMode execution currently share that tool-call ID, so the job service joins unrelated commands and some calls never receive their result.
No new metadata fields or schema changes. Background completion
jobIDnow identifies the shell job;shellIDremains the stable link to the command. Subagent jobs, the default CodeMode tool configuration, and nested output rendering are unchanged.Validation
SHELL=/bin/bashon this host.Production-build tab-switch benchmark remains inconclusive: two of three baseline samples and one of three final samples completed; the others timed out. No performance improvement or full browser-validation claim is made.
Requested by: @rekram1-node (Aiden via Slack)