Repository navigation
fix(core): reject non-UTF-8 files instead of silently corrupting them - #45925
Closed
skyzhao1223 wants to merge 1 commit into
Closed
skyzhao1223 wants to merge 1 commit into
skyzhao1223 wants to merge 1 commit into
Conversation
edit and apply_patch decoded file bytes with a non-fatal UTF-8 decoder,
replacing invalid sequences (GBK/Latin-1 comments, stray bytes) with
U+FFFD and then writing the corrupted text back to disk. Because the
replacement matched an ASCII region, the tool reported success while every
non-UTF-8 byte in the file was destroyed.
Decode with { fatal: true } and fail with an explicit 'file is not valid
UTF-8' error instead, matching the read tool's existing behavior. The file
is left untouched on failure.
This was referenced Sep 19, 2026
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #45924
Type of change
What does this PR do?
editandapply_patchdecoded file bytes with a non-fatal UTF-8 decoder, so invalid sequences (GBK/Latin-1 comments, stray bytes) were replaced with U+FFFD and the corrupted text was written back to disk. WhenoldStringmatched an ASCII region, the tool reported success while destroying every non-UTF-8 byte in the file.The fix decodes with
{ fatal: true }and fails with an explicitfile is not valid UTF-8error, leaving the file untouched — matching thereadtool's existingMalformedUtf8Errorbehavior.How did you verify your code works?
Added regression tests in both suites writing a file with GBK bytes and asserting the tool returns an error and the file bytes are unchanged:
packages/core:bun test ./test/tool-edit.test.ts ./test/tool-apply-patch.test.ts(21 pass)bun run typecheckclean, prettier cleanScreenshots / recordings
Not a UI change.
Checklist