Repository navigation
fix(mcp): retry initial 404 without injected codemode - #45563
Merged
Merged
Conversation
jinhuang712
pushed a commit
to jinhuang712/opencode
that referenced
this pull request
Sep 26, 2026
Co-authored-by: rekram1-node <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related issue: #45499
Some MCP servers return 404 when OpenCode adds
?codemode=false, even though the configured URL works.Type of change
What does this PR do?
On an initial connection 404, retry once with the original configured URL—but only if OpenCode added the
codemodeparameter.The retry lives only around connection setup, not tool calls or later requests.
How did you verify your code works?
From
packages/core:bun test test/mcp.test.ts test/mcp-instructions.test.ts test/plugin/mcp-codemode-exclusion.test.ts— 59 passed.bun typecheck— passed.Tests use a local HTTP server and the real MCP SDK. They cover successful fallback, encoded/repeated query parameters, preserved headers, a second 404, other HTTP errors, explicit
codemodevalues, and a 404 after initialization. No live Figma Desktop test.Screenshots / recordings
Not applicable; no UI changes.
Checklist
Requested by: @rekram1-node (Aiden via Slack)