Skip to content

fix(tui): ignore startup abort errors - #45489

Closed
1052326311 wants to merge 1 commit into
anomalyco:devfrom
1052326311:tui-abort-log
Closed

1052326311 wants to merge 1 commit into
anomalyco:devfrom
1052326311:tui-abort-log

Conversation

@1052326311

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #45409

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The initial TUI data refresh now treats AbortError as expected cancellation, so Ctrl+C during startup does not print cancellation stack traces. Other refresh failures are still logged.

How did you verify your code works?

On base c2eacd7, the provider-mount regression fails because both the AbortError and a real provider error are logged. With this change, only the real error remains.

  • TUI data tests: 8 passed
  • Full TUI suite: 194 passed, 1 skipped
  • TUI typecheck passed
  • Prettier and git diff --check passed

Screenshots / recordings

Not applicable; this changes shutdown stderr behavior.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@1052326311

Copy link
Copy Markdown
Contributor Author

Exact head 589476f9801252f0d47152ba4424dbe3a68abb31 is mergeable. The provider-mount regression fails on base c2eacd72afc4a4984564c393e15ab30011057269 because expected AbortError cancellation is logged, and passes on this head while retaining a real provider-error log. The full TUI suite passes 194 tests with 1 skip; TUI typecheck, Prettier, and git diff --check pass. Please review this exact head.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI prints AbortError stack traces after Ctrl+C during startup

1 participant