Repository navigation
fix(core): preserve reasoning across model switches - #45401
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #45334. This addresses readable reasoning replay, not that issue's credential-switching bug.
Type of change
What does this PR do?
Keep readable reasoning as reasoning when replaying successful messages under a different model or provider, instead of making it ordinary assistant text. Destination adapters can then use their supported reasoning format.
Metadata stripping, encrypted-only omission, same-model replay, and failed-message handling are unchanged. Adapter policies also remain unchanged: Claude falls back to text for unsigned reasoning; Responses omits reasoning without replay state rather than receiving it as ordinary text.
Updates the existing model-switch test expectation. No new test files, credential changes, or metadata-schema changes.
How did you verify your code works?
session-runner-messageandsession-model-request.bun typecheckfrompackages/corepassed.git diff --checkpassed. Oxlint reported no errors and two existing consistent-return warnings in unchanged functions.Screenshots / recordings
Not applicable.
Checklist