Repository navigation
fix(core): deliver idle synthetic notices without resuming - #45303
Closed
kitlangton wants to merge 1 commit into
Closed
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing in favor of using the existing Session.synthetic({ resume: false }) semantics in #44844. Durable inbox admission already records the notice without waking the agent; immediate placement in model history is not required for background-job recovery. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recording a synthetic status notice with
resume: falsecurrently leaves it in the inbox until a later agent run. Callers such as background-job recovery need the notice in durable Session history without starting the model or publishing internal Session events themselves.What Changes
Session.synthetic({ resume: false })now delivers an eligible idle steer immediately through the existing inbox-delivery event.Delivery Boundary
The Session API checks the next steered inbox item under the existing per-Session inbox lock and delivers only the requested notice. It does not invoke the runner's batch promotion operation, so it cannot accidentally consume neighboring user prompts. Retries keep the existing stable-ID reconciliation and first-admission behavior.
Scope
This is a standalone prerequisite for simplifying shell notifications in #44844; it does not modify that PR. User-prompt admission and model execution semantics are unchanged. Immediate user-prompt delivery would require separating runner preparation and pending-work accounting, so that broader redesign is intentionally excluded.
Verification
91028a690be4ae763141878b6c3f57b43c585d80in an isolated detached worktree.