Skip to content

fix(app): add provider visibility toggle to Settings Models - #45267

Closed
nightire wants to merge 1 commit into
anomalyco:v2from
nightire:models-provider-toggle
Closed

fix(app): add provider visibility toggle to Settings Models#45267
nightire wants to merge 1 commit into
anomalyco:v2from
nightire:models-provider-toggle

Conversation

@nightire

@nightire nightire commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #45225

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Settings → Models groups models by provider and already has a per-model visibility switch, but the provider-level master switch from Manage models was never added to this tab.

This reuses the existing providerVisible / setProviderVisibility logic in the Settings Models provider header so one switch can show or hide every model from that provider. The same i18n key (dialog.model.manage.provider.toggle) is now used for the switch label on both surfaces.

No backend or visibility-storage change.

How did you verify your code works?

Compared the Settings Models header with the Manage models dialog and ran bun typecheck in packages/app. I have not run the desktop app locally in this checkout.

Screenshots / recordings

20260826065506_rec_

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@nightire
fix(app): add provider visibility toggle to Settings Models
d207510 
Settings → Models grouped models by provider with per-model switches only.
Reuse the Manage models provider master switch so a whole provider can be
shown or hidden at once, and use the existing i18n label on both surfaces.
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@nightire
nightire marked this pull request as ready for review August 26, 2026 13:56
@github-actions

github-actions Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Sep 26, 2026
@CristianJ12 CristianJ12 mentioned this pull request Oct 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hona Hona Awaiting requested review from Hona Hona is a code owner
@Brendonovich Brendonovich Awaiting requested review from Brendonovich Brendonovich is a code owner

Assignees

No one assigned

Labels

automated-pr-cleanup needs:issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nightire